Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PADV 1018 - Changes to primary course not being reflected in the CCXs #116

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

alexjmpb
Copy link

@alexjmpb alexjmpb commented Feb 6, 2024

Ticket

https://agile-jira.pearson.com/browse/PADV-1018

Description

As 1018 describes, right now none of the CCXs are updating their outline when the outline on their corresponding master course is changed. The way it should work is, whenever the outline of a course is updated in studio, it emits the signal "course_published" and this signal should be captured by the CCX app and should update all children CCX for that course, however because the CCX app is not installed in Studio, this causes the course_published signal to not be aware of the receivers in the CCX app. Also the CCX app does not have an apps.py and thus cannot "export" the signal. This PR aims to add an apps.py to the CCX app.

Changes

  • Add apps.py to lms.djangoapps.ccx and import the signals.

How to test?

  • Setup devstack.
  • Create a course with CCX enabled.
  • Create a CCX
  • Any changes in the outline that you make in the master course should not be reflected on the CCX.
  • Checkout to this branch.
  • Inside cms.envs.devstack_docker, add the following settings:
INSTALLED_APPS += ['lms.djangoapps.ccx', 'lms.djangoapps.program_enrollments']
BULK_EMAIL_DEFAULT_RETRY_DELAY = 30
BULK_EMAIL_MAX_RETRIES = 5
  • Now any change in the outline you make to the master course should be also in the CCX.

@Nekenhei
Copy link

Nekenhei commented Feb 7, 2024

Hi @alexjmpb please update the PR letter, the issue is happening with the outline (new units and sections) of the Parent course. It's content it's being properly automatically updated by Studio on every child ccx.

Copy link

@Nekenhei Nekenhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes successfully tested

@alexjmpb alexjmpb merged commit 220ee91 into pearson-release/olive.stage Feb 13, 2024
5 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants