Add support for subqueries for the Criteria-based filtering service #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteymix
force-pushed
the
feature-filters-with-subqueries-criteria-api
branch
from
c6ad099
to
b711919
Compare
arteymix
force-pushed
the
feature-filters-with-subqueries-criteria-api
branch
from
e0759e2
to
83912d4
Compare
arteymix
force-pushed
the
development
branch
2 times, most recently
from
84692c7
to
e0ec3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of #714 for the Criteria-based API.
There's a bug I just can't figure out: no jointures are created in the subquery despites being declared with
createAlias.It's not super urgent for the 1.30 since the affected filters only involve HQL-based services.