-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store additional metadata for ExpressionExperiment and BioAssay in the database #668
Draft
arteymix
wants to merge
1
commit into
development
Choose a base branch
from
feature-additional-metadata-in-database
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
gemma-core/src/main/java/ubic/gemma/model/expression/AdditionalMetadata.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package ubic.gemma.model.expression; | ||
|
||
import lombok.Data; | ||
import lombok.EqualsAndHashCode; | ||
import ubic.gemma.model.common.Describable; | ||
import ubic.gemma.model.expression.bioAssay.BioAssay; | ||
import ubic.gemma.model.expression.experiment.ExpressionExperiment; | ||
import ubic.gemma.model.expression.experiment.MetadataType; | ||
|
||
import java.sql.Blob; | ||
|
||
/** | ||
* Metadata associated to an {@link ExpressionExperiment} or {@link BioAssay}. | ||
* @author poirigui | ||
*/ | ||
@Data | ||
@EqualsAndHashCode(of = { "id" }) | ||
public class AdditionalMetadata implements Describable { | ||
|
||
private Long id; | ||
private String name; | ||
private String description; | ||
private MetadataType type; | ||
private Blob contents; | ||
private String mediaType; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
gemma-core/src/main/java/ubic/gemma/model/expression/experiment/MetadataType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package ubic.gemma.model.expression.experiment; | ||
|
||
import ubic.gemma.model.expression.bioAssay.BioAssay; | ||
|
||
public enum MetadataType { | ||
/** | ||
* A sequencing QC report. | ||
* <p> | ||
* Example: a FastQC report attached to a specific {@link BioAssay}. | ||
*/ | ||
SEQUENCING_QC_REPORT, | ||
/** | ||
* A sequencing alignment report. | ||
* <p> | ||
* Example: STAR's Log.final.out file on a {@link BioAssay} | ||
*/ | ||
SEQUENCING_ALIGNMENT_REPORT, | ||
/** | ||
* An overall sequencing report. | ||
* <p> | ||
* Example: a MultiQC report on a {@link ExpressionExperiment} | ||
*/ | ||
SEQUENCING_OVERALL_REPORT, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ppavlidis I'm looking for some feedback for possible values to put here. If there are things that might make sense to include for microarray platforms like the output of APT tools, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already some infrastructure to support this (surfaced on diagnostics tab) but it is a low priority now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed it this morning and I synchronized all the MultiQC reports we have generated from the RNA-Seq pipeline.
I also finished adding a new argument to rnaseqDataAdd to take care of copying over the report in Gemma data directory so that it can be integrated fully in the pipeline.