Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Spring 4 #508

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from
Draft

Move to Spring 4 #508

wants to merge 2 commits into from

Conversation

arteymix
Copy link
Member

@arteymix arteymix commented Dec 4, 2022

@arteymix arteymix added this to the 1.30.0 milestone Dec 4, 2022
@arteymix arteymix force-pushed the feature-move-to-spring-4 branch 2 times, most recently from ac20945 to d9d820e Compare December 4, 2022 03:14
@arteymix arteymix mentioned this pull request Dec 4, 2022
5 tasks
</configuration>
</execution>
</executions>
</plugin>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disadvantage of using this is that IntelliJ does not see the sources and building from the IDE is likely broken.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only applies to building from scratch.

@arteymix arteymix force-pushed the feature-move-to-spring-4 branch 2 times, most recently from 307ee76 to 980f920 Compare December 4, 2022 17:58
arteymix added a commit that referenced this pull request Dec 13, 2022
This reverts commit 2a9174b.

Autowiring via constructor with CGLIB does not work in Spring 3. That
will require moving to Spring 3.

See #508.
@arteymix arteymix removed this from the 1.30.0 milestone Dec 22, 2022
@arteymix arteymix force-pushed the feature-move-to-spring-4 branch 2 times, most recently from 0a59b75 to 52f626e Compare December 26, 2022 21:07
Include depreacted SimpleFormController from Spring 3.2.18 by extracting
specific files with Maven depdendency plugin.

Update xsi:schemaLocations mentions to 4.3.

Update DWR to 3.0.2.

Update Jersey to 2.27.
pom.xml Outdated
@@ -139,7 +139,7 @@
<dependency>
<groupId>baseCode</groupId>
<artifactId>baseCode</artifactId>
<version>1.1.6</version>
<version>1.1.7</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a development version of baseCode that is based on pavlab-starter-parent.

@arteymix arteymix force-pushed the development branch 2 times, most recently from 79530fc to d612215 Compare January 26, 2023 20:05
@arteymix
Copy link
Member Author

I'm pretty sure the generated Spring sources can resize under target/generated-sources/spring-webmvc or something of the like. For IntelliJ, we only need to mark the directory accordingly.

arteymix added a commit that referenced this pull request May 8, 2023
They are currently equivalent, but in Spring 4, hasRole() will prefix
authorities with 'ROLE_'.

Relates to #508.
arteymix added a commit that referenced this pull request May 12, 2023
They are currently equivalent, but in Spring 4, hasRole() will prefix
authorities with 'ROLE_'.

Relates to #508.
@arteymix arteymix added the spring-4 Issues related to Spring 4 label Oct 10, 2023
@arteymix arteymix force-pushed the development branch 2 times, most recently from 84692c7 to e0ec3da Compare December 4, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spring-4 Issues related to Spring 4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant