Multi version IR - CP transition baed on JIT state #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavel-Durov
changed the title
Pavel-Durov
commented
Nov 26, 2024
ykrt/src/trace/swt/cp.rs
Outdated
| // ; int3 // Insert a breakpoint for GDB | ||
| ; mov rax, QWORD target_addr | ||
| ; mov [rsp], rax | ||
| ; ret |
There was a problem hiding this comment.
Before we do the jump we need to adjust rsp:
- check stack size of unopt
- calculate the difference
- sub the diff from rsp
Pavel-Durov
commented
Nov 26, 2024
| // ); | ||
|
|
||
| // asm.finalize().unwrap() | ||
| } |
Pavel-Durov
commented
Nov 26, 2024
ykrt/src/trace/swt/cp.rs
Outdated
|
|
||
| #[cfg(tracer_swt)] | ||
| fn build_livevars_cp_asm(src_smid: usize, dst_smid: usize, asm: &mut Assembler) { | ||
| let (src_rec, _) = AOT_STACKMAPS.as_ref().unwrap().get(src_smid); |
There was a problem hiding this comment.
records size is the size of the stack.
Pavel-Durov
commented
Nov 26, 2024
ykrt/src/trace/swt/cp.rs
Outdated
| 1 => dynasm!(asm | ||
| // ; mov al, BYTE [Rq(src_reg)] | ||
| // ; mov BYTE [Rq(dst_reg) + *dst_off], al# | ||
| ; mov al, BYTE [rsp + src_offset] |
There was a problem hiding this comment.
Suggested change
| ; mov al, BYTE [rsp + src_offset] | |
| ; mov al, BYTE [rbp + src_offset] |
Pavel-Durov
commented
Nov 26, 2024
ykrt/src/trace/swt/cp.rs
Outdated
| Direct(src_reg_num, src_off, src_val_size), | ||
| Direct(dst_reg_num, dst_off, dst_val_size), | ||
| ) => { | ||
| assert_eq!( |
There was a problem hiding this comment.
We don't need it probably.
Pavel-Durov
commented
Dec 9, 2024
ykrt/src/trace/swt/cp.rs
Outdated
| Direct(src_reg_num, src_off, src_val_size), | ||
| Direct(dst_reg_num, dst_off, dst_val_size), | ||
| ) => { | ||
| assert_eq!( |
ykrt/src/trace/swt/cp.rs
Outdated
| // ; pop r14 // Corresponds to push r14 | ||
| // ; pop r15 // Corresponds to push r15 | ||
| // ; ret | ||
| // ); |
There was a problem hiding this comment.
reverse the change of rsp.
ykrt/src/mt.rs
Outdated
| // let func: unsafe fn() = std::mem::transmute(debug_return_into_unopt_cp().as_ptr()); | ||
| let func: unsafe fn() = std::mem::transmute(RETURN_INTO_UNOPT_CP.as_ptr()); | ||
| // self.log.log(Verbosity::JITEvent, "returning into unopt cp"); | ||
| func(); |
There was a problem hiding this comment.
When I call my control point transition asm code the $rsp is affected (I guess by this function execution).
Expected return address at main+330: 0x7fffffffdcd0
But $rsp value when RETURN_INTO_UNOPT_CP asm is executed is 0x7fffffffd360 which is off by:
0x7fffffffdcd0 - 0x7fffffffd360 = 2416
Therefore I get segfaults downstream...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.