Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #166 APIvoid error #299

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Fix #166 APIvoid error #299

merged 4 commits into from
Apr 17, 2023

Conversation

MaKyOtOx
Copy link
Contributor

@MaKyOtOx MaKyOtOx commented Mar 14, 2023 •
edited
Loading

Fix #300

@MaKyOtOx MaKyOtOx added the fix Fix an issue/a bug label Mar 14, 2023
@MaKyOtOx MaKyOtOx requested a review from sebastien-powl March 14, 2023 15:28
@MaKyOtOx MaKyOtOx self-assigned this Mar 14, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 14, 2023 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
30.3% 30.3% Duplication

@MaKyOtOx MaKyOtOx linked an issue Mar 16, 2023 that may be closed by this pull request
APIVOID: 404 status on getreport and clean #300
Open
@sebastien-powl sebastien-powl added this to the 1.5.11 milestone Apr 17, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 17, 2023
View reviewed changes
engines/apivoid/engine-apivoid.py
res_data = {"scan": scan, "summary": summary, "issues": issues}

# Store the findings in a file
with open(f"{APP_BASE_DIR}/results/apivoid_{scan_id}.json", 'w') as report_file:

Check failure

Code scanning / SonarCloud

I/O function calls should not be vulnerable to path injection attacks

<!--SONAR_ISSUE_KEY:AYePSKOkcZCxPupmLgzU-->Change this code to not construct the path from user-controlled data. <p>See more on <a href="https://sonarcloud.io/project/issues?id=Patrowl_PatrowlEngines&issues=AYePSKOkcZCxPupmLgzU&open=AYePSKOkcZCxPupmLgzU&pullRequest=299">SonarCloud</a></p>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability E 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
30.3% 30.3% Duplication

@sebastien-powl sebastien-powl merged commit 9ebf58c into develop Apr 17, 2023
@sebastien-powl sebastien-powl deleted the 166-apivoid-errors branch April 17, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastien-powl sebastien-powl sebastien-powl approved these changes

Assignees

@MaKyOtOx MaKyOtOx

Labels
fix Fix an issue/a bug
Projects
None yet
Milestone
1.5.11
Development

Successfully merging this pull request may close these issues.

APIVOID: 404 status on getreport and clean
2 participants
@MaKyOtOx @sebastien-powl