Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-UCSC chromosome nomenclature & gzipped counts #16

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

WardDeb
Copy link
Contributor

@WardDeb WardDeb commented Oct 30, 2024

Hi,

First of all thanks for the software !
I've encountered two 'issues' when running this for my data:

  • when using an 'ensembl' based genome (forged BSgenome myself), the chromosomes are named 1,2,.... The pattern matching under list.files thus fails (i.e. 1.rda, 11.rda). I've changed this just a file.path, as I think it's fair to assume that (even in the UCSC case) there'll always be one (and only one) file matching.
  • the write.table - gzip chain for writing out the counts failed on our system (relatively slow disks), the workaround for this is to directly write out the counts file.

Cheers,

WardDeb

@mireia-bioinfo mireia-bioinfo merged commit 77a7dc1 into Pasquali-lab:master Oct 31, 2024
0 of 3 checks passed
@mireia-bioinfo
Copy link
Member

Hi!

Thank you so much for taking the time to fix this 'issues'. I've now merged them into the master branch. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants