Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move execute_task() to a dedicated module #3701

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

rjmello
Copy link
Member

@rjmello rjmello commented Nov 19, 2024

Description

Multiple executors use the execute_task() function, so moving it to its own module improves code organization and reusability.

Also removed MPI-related code from execute_task(), as it's specific to the HTEX.

Type of change

  • Code maintenance/cleanup

Copy link
Collaborator

@khk-globus khk-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A split-up request, but otherwise, looks good!

parsl/tests/test_execute_task.py Show resolved Hide resolved
parsl/executors/high_throughput/process_worker_pool.py Outdated Show resolved Hide resolved
Multiple executors use the `execute_task()` function, so moving it to
its own module improves code organization and reusability.
@rjmello rjmello force-pushed the rjmello-execute-task branch from ca0bbbe to ae86461 Compare November 19, 2024 17:25
@rjmello rjmello requested a review from khk-globus November 19, 2024 17:26
Copy link
Collaborator

@khk-globus khk-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for the precursor PR. Much clearer exactly what the intended change was for this PR.

Thanks for this cleanup!

@khk-globus khk-globus added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit 8f0c5a1 Nov 19, 2024
7 checks passed
@khk-globus khk-globus deleted the rjmello-execute-task branch November 19, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants