Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ZMQ, UDP and filesystem monitoring routers send via radios #3700

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

benclifford
Copy link
Collaborator

This PR is intended to consolidate monitoring message sending in the monitoring radio code.

This is a step towards removing Python multiprocessing from the monitoring code base (see issue #2343) by making it clearer how to change to a different message send implementation (by swapping out the radio implementation and configuration)

Compare to how the interchange forwards HTEXRadio messages onwards via some other radio (which right now is always the ZMQRadioSender) -- rather than having its own ZMQ code.

Changed Behaviour

none

Type of change

  • Code maintenance/cleanup

This PR is intended to consolidate monitoring message sending in the
monitoring radio code.

This is a step towards removing Python multiprocessing from the
monitoring code base (see issue #2343) by making it clearer how to change
to a different message send implementation (by swapping out the radio
implementation and configuration)

Compare to how the interchange forwards HTEXRadio messages onwards via
some other radio (which right now is always the ZMQRadioSender) -- rather
than having its own ZMQ code.
@benclifford benclifford added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit 3eb7e93 Nov 14, 2024
7 checks passed
@benclifford benclifford deleted the benc-monitoring-via-radios branch November 14, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants