Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused channel directory handling code #3689

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Remove unused channel directory handling code #3689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions parsl/channels/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,31 +80,3 @@ def pull_file(self, remote_source: str, local_dir: str) -> str:
destination_path (string)
'''
pass

@abstractmethod
def makedirs(self, path: str, mode: int = 0o511, exist_ok: bool = False) -> None:
"""Create a directory.

If intermediate directories do not exist, they will be created.

Parameters
----------
path : str
Path of directory to create.
mode : int
Permissions (posix-style) for the newly-created directory.
exist_ok : bool
If False, raise an OSError if the target directory already exists.
"""
pass

@abstractmethod
def isdir(self, path: str) -> bool:
"""Return true if the path refers to an existing directory.

Parameters
----------
path : str
Path of directory to check.
"""
pass
28 changes: 0 additions & 28 deletions parsl/channels/local/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,34 +91,6 @@ def push_file(self, source, dest_dir):
def pull_file(self, remote_source, local_dir):
return self.push_file(remote_source, local_dir)

def isdir(self, path):
"""Return true if the path refers to an existing directory.

Parameters
----------
path : str
Path of directory to check.
"""

return os.path.isdir(path)

def makedirs(self, path, mode=0o700, exist_ok=False):
"""Create a directory.

If intermediate directories do not exist, they will be created.

Parameters
----------
path : str
Path of directory to create.
mode : int
Permissions (posix-style) for the newly-created directory.
exist_ok : bool
If False, raise an OSError if the target directory already exists.
"""

return os.makedirs(path, mode, exist_ok)

@property
def script_dir(self):
return self._script_dir
Expand Down
Loading