Make deliberately scaled-in unstarted blocks not be failures #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validated that it fails when run against master 789ee82
…ause scaled down blocks are no longer failures, so this test should not do any scale down
benclifford
changed the title
benclifford
requested review from
khk-globus,
yadudoc and
rjmello
and removed request for
khk-globus
khk-globus
approved these changes
Aug 26, 2024
| # permanent htex failure, and so the task execution below would raise | ||
| # a BadStateException rather than attempt to run the task. | ||
|
|
||
| assert htex.provider.launcher.prepend != "", "Pre-req: prepend attribute should exist and be non-empty" |
There was a problem hiding this comment.
Would use of .startswith() work? If so, it makes for a stronger assertion / good faith in the test. Perhaps:
_inf_sleep = "sleep inf ; "
...
launcher=WrappedLauncher(prepend=_inf_sleep),
...
assert htex.provider.launcher.prepend.startswith(_inf_sleep), "..."
Comment on lines
+68
to
+69
| try_assert(lambda: len(htex.status_facade) == 1 and htex.status_facade['0'].terminal, | ||
| timeout_ms=10000) |
There was a problem hiding this comment.
Consider using the fail_msg argument to explain that this is a block. (Analogous to assert ..., "fail_msg")
Comment on lines
+84
to
+85
| htex.provider.launcher.prepend = "" | ||
| assert task().result() == 7 |
There was a problem hiding this comment.
Can you distill the comment above into the fail msg for this assert? Not an easy task, I know, but when this does fail, makes it that easier to dig in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new terminal job state, SCALED_IN. None of the existing providers will return it, but the scaling layer will use it to mark a job as deliberately scaled in, so that error handling code will not regard it as failed.
Fixes #3568