Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to squeue when sacct is missing in SlurmProvider #3591

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

tylern4
Copy link
Contributor

@tylern4 tylern4 commented Aug 16, 2024

Description

Adds internal check to test whether the slurm provider should use the sacct or squeue command.

Changed Behaviour

Some slurm clusters might not use the accounting database sacct uses. This allows slurm clusters that use the database to use the sacct command which can be easier on the slurm scheduler, or if the database is not present switch to the squeue command which will should work on all clusters.

Fixes

Fixes #3590

Type of change

  • Bug fix

@benclifford
Copy link
Collaborator

Great!

Can you confirm you tested it with both sacct and squeue?

and @raymondEhlers did you test it?

If so I can avoid any testing myself and merge it for the auto-release on Monday.

@raymondEhlers
Copy link

Yes, we will test it and report back, although probably not before Monday (I missed you reply, apologies)

@benclifford
Copy link
Collaborator

Yes, we will test it and report back, although probably not before Monday (I missed you reply, apologies)

cool thanks. There's no tight deadline on this.

@fjonasALICE
Copy link

Apologies for the late reply and thank you for the fast fix. I tested locally on our cluster and the fix works as expected. Thanks!

@benclifford benclifford changed the title Use sacct or squeue Fallback to squeue when sacct is missing in SlurmProvider Aug 20, 2024
@benclifford benclifford merged commit bdfbb26 into Parsl:master Aug 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: parsl fails on small slurm clusters without slurm accounting
4 participants