Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warning about provider options in MPI context #3516

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

yadudoc
Copy link
Member

@yadudoc yadudoc commented Jul 9, 2024

Description

Parsl providers assume a pilot job model, where a single manager runs per node. This model conflicts with the model that MPIExecutor uses where the scheduler starts a single manager on the entire job which then launches MPI apps. This PR adds a warning to documentation cautioning use of cores_per_node in the SlurmProvider and similar options.

This PR comes Christopher Harrop from NOAA reported on the help channel.

Type of change

Choose which options apply, and delete the ones which do not apply.

  • Update to human readable text: Documentation/error messages/comments

@yadudoc yadudoc requested a review from benclifford July 9, 2024 16:26
@benclifford
Copy link
Collaborator

benclifford commented Jul 9, 2024

"interact poorly" is kinda hands-off phrasing I'd expect from a British person... Does this mean danger do not set these options?

@yadudoc
Copy link
Member Author

yadudoc commented Jul 23, 2024

Hey @benclifford I've updated the text to be less "British" :)

@yadudoc yadudoc force-pushed the mpi_doc_updates branch 3 times, most recently from 754931c to 4342b40 Compare July 24, 2024 00:11
Warns users about per-task and per-node options to the provider conflicting with MPIExecutor
@yadudoc yadudoc merged commit a2af30c into master Jul 24, 2024
7 checks passed
@yadudoc yadudoc deleted the mpi_doc_updates branch July 24, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants