Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options to set annotations and a service account in the Kuberne… #3476

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

shishichen
Copy link
Contributor

…tes worker pod configuration

Description

Added options for pod annotations and a service account to be used by the pod, which are passed through to the Kubernetes client. These options are needed when using the provider on Google Kubernetes Engine for pods to mount Google Cloud Storage persistent volumes.

Changed Behaviour

Enables additional options to be configured on the Kubernetes worker pods.

Fixes

Fixes # n/a - minor change

Type of change

  • New feature

@benclifford
Copy link
Collaborator

cool I'll try this out on my kubernetes cluster. @trey-stafford @mfisher87 might be in a better place to review this PR than me though.

Copy link
Collaborator

@benclifford benclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested out that pods start up with an alternate service account and with some basic annotations.

@benclifford benclifford merged commit 2200f62 into Parsl:master Jun 10, 2024
6 checks passed
@shishichen
Copy link
Contributor Author

Thanks for the review!

@shishichen shishichen deleted the add-k8s-pod-options branch June 10, 2024 13:37
@mfisher87
Copy link
Contributor

@benclifford thanks for looping us in! Unfortunately, our time commitment is temporarily coming to an end this week and don't have time for an in-depth review amongst the other tie-up tasks. We'll be looking at this work again in October! The Python looks great, but my context is super limited :)

One comment not related to this PR: I see some docstrings that have type hints in them, but there are also real Python type annotations on those methods & classes. Does your autodoc engine read the Python type annotations? In which case the docstring hints could be removed to simplify maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants