Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove environment variable configuration for usage tracking #3466

Merged

Conversation

NishchayKarle
Copy link
Contributor

@NishchayKarle NishchayKarle commented Jun 3, 2024

Description

This PR removes the use of $PARSL_TRACKING env variable to setup usage tracking configuration. Parsl will now only take usage tracking configuration from the config

Changed Behavior

Anyone using only the env variable PARSL_TRACKING to enable usage tracking will need to set usage_tracking = True within the config to enable usage tracking.

Fixes

Fixes #3456

Type of change

  • Code maintenance/cleanup
  • Update documentation

Copy link
Collaborator

@benclifford benclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple other places where that variable is mentioned. I used git grep to find them:

$ git grep PARSL_TRACKING
docs/quickstart.rst:You can opt-in by setting ``PARSL_TRACKING=true`` in your environment or by 
docs/userguide/usage_tracking.rst:If you wish to opt in to usage reporting, set ``PARSL_TRACKING=true`` in your environment or set ``usage_tracking=True`` in the configuration object (`parsl.config.Config`).

This PR should fix those references too

@benclifford benclifford changed the title Remove env variable usage tracking Remove environment variable configuration for usage tracking Jun 3, 2024
@benclifford benclifford merged commit 804fb32 into Parsl:master Jun 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] remove PARSL_TRACKING environment variable
2 participants