Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provider list in execution guide #3145

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Update provider list in execution guide #3145

merged 1 commit into from
Mar 6, 2024

Conversation

MunishMummadi
Copy link
Contributor

Description

Added a deprecation notice for the CobaltProvider and updated the list of supported providers in the execution.rst file.

Changed Behavior

  • Users will now see a deprecation notice for the CobaltProvider in the execution.rst file.
  • Updated the list of supported providers to include all available options.

Fixes

N/A

Type of change

  • Update to human-readable text: Documentation

@MunishMummadi
Copy link
Contributor Author

I think checks are stopped due to the 60 minutes timeout. Correct me if I am wrong. And i would like to raise an issue to increase timeout.

Copy link
Member

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MunishMummadi These changes look good to me 👍 Good job!

@yadudoc
Copy link
Member

yadudoc commented Mar 5, 2024

I've restarted that failed CI test, once that passes feel free to merge this PR.

@MunishMummadi
Copy link
Contributor Author

Thank you. @yadudoc . I will merge it.

@@ -48,7 +48,8 @@ Parsl currently supports the following providers:
8. `parsl.providers.GoogleCloudProvider`: This provider allows you to provision and manage cloud nodes from Google Cloud.
9. `parsl.providers.KubernetesProvider`: This provider allows you to provision and manage containers on a Kubernetes cluster.
10. `parsl.providers.AdHocProvider`: This provider allows you manage execution over a collection of nodes to form an ad-hoc cluster.
11. `parsl.providers.LSFProvider`: This provider allows you to schedule resources via IBM's LSF scheduler
11. `parsl.providers.LSFProvider`: This provider allows you to schedule resources via IBM's LSF scheduler.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to avoid making other incidental changes that aren't part of the issue you are working on - for example, your PR title is about notices on the CobaltProvider, but this change here is nothing to do with the cobalt provider! I'll put a new title on the PR that is a bit more broad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really sorry for that. I am a rookie. Thank you for the feedback.

@benclifford benclifford changed the title Add deprecation notice for CobaltProvider Update provider list in execution guide Mar 6, 2024
@benclifford benclifford merged commit f2423b7 into Parsl:master Mar 6, 2024
6 checks passed
@benclifford
Copy link
Collaborator

merged. thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants