Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce flake8 max-line-length #3144

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@
# W504: line break after binary operator
# (Raised by flake8 even when it is followed)
ignore = E126, E402, E129, W504
max-line-length = 152
max-line-length = 131
exclude = test_import_fail.py,
parsl/executors/workqueue/parsl_coprocess.py
parsl/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a mistake here: it looks like you've split the line containing parsl/executors/workqueue/parsl_coprocess.py into two separate lines, and now the new version says to ignore all errors in the whole of parsl!

executors/workqueue/parsl_coprocess.py
# E741 disallows ambiguous single letter names which look like numbers
# We disable it in visualization code because plotly uses 'l' as
# a keyword arg
Expand Down
1 change: 1 addition & 0 deletions hello1.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hello World!
1 change: 1 addition & 0 deletions output.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2
12 changes: 12 additions & 0 deletions t.err
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
--> executable follows <--
echo "Hello world"; echo "Hello world" >&2
--> end executable <--
Hello world
--> executable follows <--
echo "Hello world"; echo "Hello world" >&2
--> end executable <--
Hello world
--> executable follows <--
echo "Hello world"; echo "Hello world" >&2
--> end executable <--
Hello world
Loading