Fix for TypeError when --available-accelerators is not specificied in htex process worker pool #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclifford
reviewed
Mar 5, 2024
| @@ -824,7 +824,7 @@ def strategyorlist(s: str): | |||
| required=True, | |||
| help="Whether/how workers should control CPU affinity.") | |||
| parser.add_argument("--available-accelerators", type=str, nargs="*", | |||
| help="Names of available accelerators") | |||
| help="Names of available accelerators, If not given Assumed to be zero accelerators available", default=[]) | |||
There was a problem hiding this comment.
don't capitalize if and Assumed here
|
thanks, I'll try this out in my development environment |
|
Ok sir, let me know if any changes to be made |
|
@Harichandra-Prasath, it looks like @benclifford is waiting for you to make the capitalization changes he recommended in his comments. Could you take a look at that, please? Once those changes are made we can merge this PR. |
|
@yadudoc Made the changes sir. |
|
All tests are passed sir |
benclifford
changed the title
benclifford
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix of type error for the argument handling for accelerators-available
Changed Behaviour
There wont be typeError if no arguments are passed for acceleratots-available. Defaulted to zero
Fixes
Fixes #3110
Type of change
Choose which options apply, and delete the ones which do not apply.