Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip two tests that are blocking CI with hangs #3090

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

benclifford
Copy link
Collaborator

These tests are highlighting issues raised in issue #3029 and #3089, and should be re-instated as part of resolving those issues.

Between them, the hangs of these tests meant that it was becoming hard, and in some cases apparently impossible, to merge new PRs.

Changed Behaviour

This PR reduces test coverage, which leads to increased unreliability in the codebase.

Type of change

  • Code maintenance/cleanup

These tests are highlighting issues raised in issue #3029 and #3089,
and should be re-instated as part of resolving those issues.

Between them, the hangs of these tests meant that it was becoming
hard, and in some cases apparently impossible, to merge new PRs.
@benclifford benclifford merged commit 87473c0 into master Feb 20, 2024
6 checks passed
@benclifford benclifford deleted the benc-skip-hangs branch February 20, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants