Verify Interchange terminates on HTEX shutdown #3081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmello
added
bug
executor:htex
globus-compute
rjmello
force-pushed
the
htex-shutdown-#3080
branch
from
6970725 to
792b52e
Compare
khk-globus
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Looks good to me, though I don't see a need for hasattr(), and an open question regarding whether we .kill() the process. I don't currently have in mind the larger setup here, so ... either wait until Monday, or get @benclifford to chime in. 😉
rjmello
force-pushed
the
htex-shutdown-#3080
branch
from
792b52e to
5299112
Compare
rjmello
force-pushed
the
htex-shutdown-#3080
branch
from
5299112 to
c5a0ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We give the Interchange process 10 seconds to terminate when calling the HTEX
shutdown()method. If it doesn't terminate after 10 seconds, we'll add an informative log to notify the user of the stuck process, and then continue.I've also updated the tests in
test_htex.pyto ensure we callhtex.shutdown()at the end of each test.Fixes #3080
Type of change