Re-enable str-bytes-safe mypy error, and fix uses #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are all in the interchange. In most cases, this error is found when a manager id (a byte sequence) is used in a string substitution, and to make happy, the format string is modified to indicate that we really do want to represent that byte sequence as a repr. The only other place is one rendering of a binary message into a log string, and the fix is the same. from benc-mypy branch
khk-globus
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are all in the interchange. In most cases, this error is found when a manager id (a byte sequence) is used in a string substitution, and to make happy, the format string is modified to indicate that we really do want to represent that byte sequence as a repr.
The only other place is one rendering of a binary message into a log string, and the fix is the same.
from benc-mypy branch
Type of change