Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain exceptions on WorkQueueTaskFailure when a cause is available #2910

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

benclifford
Copy link
Collaborator

@benclifford benclifford commented Oct 14, 2023

This will add exception chaining when an underlying exception is available, so that reporting of a WorkQueueTaskError will include before the WorkQueueTaskError. This means, in the case of a FileNotFoundError, that the filename that could not be found will now be reported.

 FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/parsl/parsl/runinfo/003/WorkQueueExecutor/function_data/0011/result'

parsl/executors/workqueue/executor.py:1059: FileNotFoundError

The above exception was the direct cause of the following exception:

benclifford added a commit that referenced this pull request Oct 14, 2023
@benclifford benclifford changed the title not for merge: tidying up error handling around some race-like condition appearing in WQ tests in CI Chain exceptions on WorkQueueTaskFailure when a cause is available Oct 14, 2023
@benclifford benclifford marked this pull request as ready for review October 14, 2023 19:52
@benclifford
Copy link
Collaborator Author

@dthain maybe you have someone to review this

See issue #2914 for the motivating issue that I am debugging.

@benclifford benclifford merged commit 9ed5f5e into master Oct 23, 2023
4 checks passed
@benclifford benclifford deleted the benc-tmp-wqex branch October 23, 2023 18:32
@benclifford
Copy link
Collaborator Author

I discussed this with @tphung3 and I think he's ok with me merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant