Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix build failure in readthedocs #2907

Closed
wants to merge 3 commits into from
+14 −16
Closed

Attempt to fix build failure in readthedocs #2907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ddcc54
add whitespace to try something with readthedocs
benclifford Oct 13, 2023
30ac4ca
hack away ndcctools port
benclifford Oct 13, 2023
fdb9113
hack away ndcctools port
benclifford Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions docs/userguide/configuring.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,18 +105,18 @@ Stepping through the following question should help formulate a suitable configu
2. How many nodes will be used to execute the apps? What task durations are necessary to achieve good performance?


+--------------------------------------------+----------------------+-------------------------------------+
| Executor | Number of Nodes [*]_ | Task duration for good performance |
+============================================+======================+=====================================+
| `parsl.executors.ThreadPoolExecutor` | 1 (Only local) | Any |
+--------------------------------------------+----------------------+-------------------------------------+
| `parsl.executors.HighThroughputExecutor` | <=2000 | Task duration(s)/#nodes >= 0.01 |
| | | longer tasks needed at higher scale |
+--------------------------------------------+----------------------+-------------------------------------+
| `parsl.executors.WorkQueueExecutor` | <=1000 [*]_ | 10s+ |
+--------------------------------------------+----------------------+-------------------------------------+
| `parsl.executors.taskvine.TaskVineExecutor`| <=1000 [*]_ | 10s+ |
+--------------------------------------------+----------------------+-------------------------------------+
+---------------------------------------------+----------------------+-------------------------------------+
| Executor | Number of Nodes [*]_ | Task duration for good performance |
+=============================================+======================+=====================================+
| `parsl.executors.ThreadPoolExecutor` | 1 (Only local) | Any |
+---------------------------------------------+----------------------+-------------------------------------+
| `parsl.executors.HighThroughputExecutor` | <=2000 | Task duration(s)/#nodes >= 0.01 |
| | | longer tasks needed at higher scale |
+---------------------------------------------+----------------------+-------------------------------------+
| `parsl.executors.WorkQueueExecutor` | <=1000 [*]_ | 10s+ |
+---------------------------------------------+----------------------+-------------------------------------+
| `parsl.executors.taskvine.TaskVineExecutor` | <=1000 [*]_ | 10s+ |
+---------------------------------------------+----------------------+-------------------------------------+


.. [*] Assuming 32 workers per node. If there are fewer workers launched
Expand Down
2 changes: 0 additions & 2 deletions parsl/executors/taskvine/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
from parsl.process_loggers import wrap_with_logs
from parsl.executors.taskvine.errors import TaskVineFactoryFailure

from ndcctools.taskvine import Factory

logger = logging.getLogger(__name__)


Expand Down
4 changes: 2 additions & 2 deletions parsl/executors/taskvine/manager_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from dataclasses import dataclass
from typing import Optional

from ndcctools.taskvine.cvine import VINE_DEFAULT_PORT
# from ndcctools.taskvine.cvine import VINE_DEFAULT_PORT


@dataclass
Expand Down Expand Up @@ -142,7 +142,7 @@ class TaskVineManagerConfig:
"""

# Connection and communication settings
port: int = VINE_DEFAULT_PORT
port: int = 99999999
address: str = socket.gethostname()
project_name: Optional[str] = None
project_password_file: Optional[str] = None
Expand Down
Loading