Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make max_threads type Optional[int] in ThreadPoolExecutor #2902

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Make max_threads type Optional[int] in ThreadPoolExecutor #2902

merged 1 commit into from
Oct 9, 2023

Conversation

Andrew-S-Rosen
Copy link
Contributor

@Andrew-S-Rosen Andrew-S-Rosen commented Oct 9, 2023 •
edited
Loading

Description

The ThreadPoolExecutor forces the max_threads kwarg to be of type int. However, since max_threads inevitably makes its way into concurrent.futures.ThreadPoolExecutor, which can take max_workers=None, I have modified the type hint to be Optional[int].

Happy to add a test if you feel it warrants one.

Type of change

Choose which options apply, and delete the ones which do not apply.

  • New feature (non-breaking change that adds functionality)

@benclifford benclifford merged commit d155786 into Parsl:master Oct 9, 2023
4 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the patch-1 branch October 9, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andrew-S-Rosen @benclifford