Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return a value from a pytest case, to fix a deprecation warning #2898

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

benclifford
Copy link
Collaborator

This fixes this pytest warning:

PytestReturnNotNoneWarning: Expected None, but
test_bash_apps/test_error_codes.py::test_div_0 returned True, which
will be an error in a future version of pytest.
Did you mean to use assert instead of return?

Type of change

  • Code maintentance/cleanup

This fixes this pytest warning:

  PytestReturnNotNoneWarning: Expected None, but
  test_bash_apps/test_error_codes.py::test_div_0 returned True, which
  will be an error in a future version of pytest.
  Did you mean to use `assert` instead of `return`?
Copy link
Collaborator

@khk-globus khk-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! One more down!

@benclifford benclifford merged commit bd41754 into master Oct 4, 2023
4 checks passed
@benclifford benclifford deleted the benc-pytest-fix branch October 4, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants