Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable code when app_fu is None #2881

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

benclifford
Copy link
Collaborator

The task record entry app_fu is never None:
it is either missing (during construction) or a Future.

So, this None check will never fire.

Discovered by mypy 0.5.1 warn_unreachable

Type of change

  • Code maintentance/cleanup

The task record entry app_fu is never None:
it is either missing (during construction) or a Future.

So, this None check will never fire.

Discovered by mypy 0.5.1 warn_unreachable
Copy link
Collaborator

@khk-globus khk-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed; nice find. (Is that mypy 1 .5.1?) Heh.

@khk-globus khk-globus merged commit b09b8dc into master Sep 18, 2023
4 checks passed
@khk-globus khk-globus deleted the benc-mypy-appfu-None branch September 18, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants