Loosen typeguard upper bound to allow major version 4 #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a Pytest upgrade first, which I'll do in a different PR |
|
I fixed up a test to look for typeguards new TypeCheckError, but that now fails on typeguard 2.x (which is not tested by CI as it's installing 4.x):
E AttributeError: module 'typeguard' has no attribute 'TypeCheckError' |
|
That's a concern for me mostly because typeguard>2 is relatively new and I'm wary of increasing the minimum bound there... |
|
got this in CI - will rerun and see what happens |
khk-globus
added a commit
that referenced
this pull request
Jul 21, 2023
As seen in CI at least once, it's possible that the noop() function takes too
long to complete. Address by:
- increasing the timeout
- removing the now-deemed-extraneous other parameterizations
- and verifying the test pre-condition first. ("We expect to get a result!")
Reference problem observed: #2812 (comment)
benclifford
pushed a commit
that referenced
this pull request
Jul 21, 2023
As seen in CI at least once, it's possible that the noop() function takes too
long to complete. Address by:
- increasing the timeout
- removing the now-deemed-extraneous other parameterizations
- and verifying the test pre-condition first. ("We expect to get a result!")
Reference problem observed: #2812 (comment)
|
typeguard 4.0.1, released on 27th July, introduces new complications ... see agronholm/typeguard#372 I think this is a typeguard bug. |
benclifford
added a commit
that referenced
this pull request
Nov 13, 2023
commit fa66de4 Merge: 46f0a5f c39700b Author: Ben Clifford <[email protected]> Date: Thu Jul 20 08:15:14 2023 +0000 Merge remote-tracking branch 'origin/master' into benc-typeguard-4 commit 46f0a5f Author: Ben Clifford <[email protected]> Date: Wed Jul 19 15:10:34 2023 +0000 Remote unused from __future__ import commit b8e5cb9 Author: Ben Clifford <[email protected]> Date: Wed Jul 19 14:23:51 2023 +0000 Upgrade typeguard, because TypeCheckError is new in typeguard 4 commit b452efd Author: Ben Clifford <[email protected]> Date: Wed Jul 19 13:02:32 2023 +0000 Expect a different type error in tests with typeguard 4.0.0 commit 177f1e4 Merge: 70e0879 b9f2ca3 Author: Ben Clifford <[email protected]> Date: Wed Jul 19 12:54:16 2023 +0000 Merge remote-tracking branch 'origin/master' into benc-typeguard-4 commit 70e0879 Merge: acde393 a001fe2 Author: Ben Clifford <[email protected]> Date: Tue Jul 18 15:00:08 2023 +0200 Merge branch 'master' into benc-typeguard-4 commit acde393 Author: Ben Clifford <[email protected]> Date: Wed Jul 12 08:03:59 2023 +0000 Loosen typeguard upper bound to allow major version 4
|
reworked this into #3044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most immediately driven by installing parsl on top of the lsst_distrib stack which currently has a recent typeguard.
Type of change