Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider block submission scripts should contain a block number to correlate with block logs #2692

Closed
benclifford opened this issue May 12, 2023 · 0 comments
Closed

provider block submission scripts should contain a block number to correlate with block logs #2692

benclifford opened this issue May 12, 2023 · 0 comments
Labels
enhancement

Comments

@benclifford
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
When running with multiple blocks, it is difficult to correlate the batch system logs which appear under runinfo/NNN/submit_scripts and are identified by a microsecond timestamp.

Another issue requests that these files should not use timestamps like this because they are long but closely correllated -#1122

Describe the solution you'd like
The relevant block (executor name and block number) should appear either in the submission script log filenames or in the log files themselves, or both.

Additional context
This is a feature for usability of debugging.
benclifford added a commit that referenced this issue May 15, 2023
@benclifford
Put executor name and block ID in provider submit script filenames
460d181 
Prior to this PR, submit script filenames looked like this:

parsl.localprovider.1684151066.651144.sh

After this PR, submit script filenames look like this:

parsl.htex_Local.block-0.1684154520.747874.sh

This PR fixes feature request issue #2692, which requests that the
filename contain more block identifying context, for correlation with
other block-related log files.

Also adds some more uniqueness which is relevant to issue #1122 and
addresses the naming collisions I have experienced in that context.
@benclifford benclifford mentioned this issue May 15, 2023
Merged
benclifford added a commit that referenced this issue May 25, 2023
@benclifford
Put executor name and block ID in provider submit script filenames (#…
2d748ef 
…2710)

Prior to this PR, submit script filenames looked like this:

parsl.localprovider.1684151066.651144.sh

After this PR, submit script filenames look like this:

parsl.htex_Local.block-0.1684154520.747874.sh

This PR fixes feature request issue #2692, which requests that the filename contain more block identifying context, for correlation with other block-related log files.

Also adds some more uniqueness which is relevant to issue #1122 and addresses the naming collisions I have experienced in that context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benclifford