Skip to content

Commit

Permalink
Put executor name and block ID in provider submit script filenames (#…
Browse files Browse the repository at this point in the history
…2710)

Prior to this PR, submit script filenames looked like this:

parsl.localprovider.1684151066.651144.sh

After this PR, submit script filenames look like this:

parsl.htex_Local.block-0.1684154520.747874.sh

This PR fixes feature request issue #2692, which requests that the filename contain more block identifying context, for correlation with other block-related log files.

Also adds some more uniqueness which is relevant to issue #1122 and addresses the naming collisions I have experienced in that context.
  • Loading branch information
benclifford authored May 25, 2023
1 parent 3e66d9a commit 2d748ef
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion parsl/executors/status_handling.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,9 @@ def scale_out(self, blocks: int = 1) -> List[str]:

def _launch_block(self, block_id: str) -> Any:
launch_cmd = self._get_launch_command(block_id)
job_id = self.provider.submit(launch_cmd, 1)
job_name = f"parsl.{self.label}.block-{block_id}"
logger.debug("Submitting to provider with job_name %s", job_name)
job_id = self.provider.submit(launch_cmd, 1, job_name)
if job_id:
logger.debug(f"Launched block {block_id} on executor {self.label} with job ID {job_id}")
else:
Expand Down

0 comments on commit 2d748ef

Please sign in to comment.