Skip to content

Commit

Permalink
Remove return from shutdown
Browse files Browse the repository at this point in the history
  • Loading branch information
yadudoc committed Nov 14, 2024
1 parent 287785f commit b47204a
Showing 1 changed file with 13 additions and 12 deletions.
25 changes: 13 additions & 12 deletions parsl/executors/globus_compute.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,28 +98,29 @@ def __init__(
self.batch_size = batch_size
self.amqp_port = amqp_port
self.client = client
self.executor_kwargs = kwargs

if not _globus_compute_enabled:
raise OptionalModuleMissing(
['globus-compute-sdk'],
"GlobusComputeExecutor requires globus-compute-sdk installed"
)

def start(self) -> None:
""" Start the Globus Compute Executor """

self._executor: Executor = Executor(
endpoint_id=endpoint_id,
task_group_id=task_group_id,
resource_specification=resource_specification,
user_endpoint_config=user_endpoint_config,
label=label,
batch_size=batch_size,
amqp_port=amqp_port,
endpoint_id=self.endpoint_id,
task_group_id=self.task_group_id,
resource_specification=self.resource_specification,
user_endpoint_config=self.user_endpoint_config,
label=self.label,
batch_size=self.batch_size,
amqp_port=self.amqp_port,
client=self.client,
**kwargs
**self.executor_kwargs
)

def start(self) -> None:
pass

def submit(self, func: Callable, resource_specification: Dict[str, Any], *args: Any, **kwargs: Any) -> Future:
""" Submit func to globus-compute
Expand Down Expand Up @@ -164,4 +165,4 @@ def shutdown(self):
GCE.shutdown will cancel all futures that have not yet registered with
Globus Compute and will not wait for the launched futures to complete.
"""
return self._executor.shutdown(wait=False, cancel_futures=True)
self._executor.shutdown(wait=False, cancel_futures=True)

0 comments on commit b47204a

Please sign in to comment.