Skip to content

Commit

Permalink
Upgrade mypy
Browse files Browse the repository at this point in the history
  • Loading branch information
benclifford committed Sep 15, 2023
1 parent f4d5408 commit 5804420
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion parsl/monitoring/monitoring.py
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,12 @@ def start(self,
if 'exit_now' in msg[1] and msg[1]['exit_now']:
router_keep_going = False
else:
self.logger.error(f"Discarding message from interchange with unknown type {msg[0].value}")
# There is a type: ignore here because if msg[0]
# is of the correct type, this code is unreachable,
# but there is no verification that the message
# received from ic_channel.recv_pyobj() is actually
# of that type.
self.logger.error(f"Discarding message from interchange with unknown type {msg[0].value}") # type: ignore[unreachable]
except zmq.Again:
pass
except Exception:
Expand Down
2 changes: 1 addition & 1 deletion test-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ pytest-random-order
mock>=1.0.0
nbsphinx
sphinx_rtd_theme
mypy==1.1.1
mypy==1.5.1
types-python-dateutil
types-requests
types-six
Expand Down

0 comments on commit 5804420

Please sign in to comment.