Skip to content

Commit

Permalink
add a todo on checkpoint policy position
Browse files Browse the repository at this point in the history
  • Loading branch information
benclifford committed Aug 22, 2024
1 parent 1745e7e commit 333c7eb
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions parsl/dataflow/dflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ def __init__(self, config: Config) -> None:
self.monitoring.send(MessageType.WORKFLOW_INFO,
workflow_info)

# TODO: this configuration should become part of the particular memoizer code
# - this is a checkpoint-implementation-specific parameter
if config.checkpoint_files is not None:
checkpoint_files = config.checkpoint_files
elif config.checkpoint_files is None and config.checkpoint_mode is not None:
Expand Down Expand Up @@ -198,6 +200,10 @@ def __init__(self, config: Config) -> None:
self.add_executors(config.executors)
self.add_executors([parsl_internal_executor])

# TODO: these checkpoint modes should move into the memoizer implementation
# they're (probably?) checkpointer specific: for example the sqlite3-pure-memoizer
# doesn't have a notion of building up an in-memory checkpoint table that needs to be
# flushed on a separate policy
if self.checkpoint_mode == "periodic":
if config.checkpoint_period is None:
raise ConfigurationError("Checkpoint period must be specified with periodic checkpoint mode")
Expand Down

0 comments on commit 333c7eb

Please sign in to comment.