Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't forward worker heartbeats to the submit side (#3634)
Prior to this PR, heartbeats sent from worker pools to the interchange on the results channel would be forwarded on to the submit side along the interchange to submit side results channel. These heartbeat messages would then be discarded on the submit side. I think these forwarded messages don't do anything, so this PR removes the forwarding. The network path between interchange and submit side is on localhost and unlikely to need any TCP level keepalives. There is no handling for missing heartbeats, and indeed no expectation of heartbeats arriving: an interchange might exist for many hours with no connected workers, and so no forwarded heartbeats. This PR should reduce message load on the submit side results channel by one message per work pool per heartbeat period. See issue #3464 for further context.
- Loading branch information