Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny cleanup #507

Merged
Merged

Conversation

brownbaerchen
Copy link
Contributor

I was surprised by how much more memory diagonal SDC needs compared to space-only parallelism. Unfortunately, I didn't find an easy solution. Instead, I just removed one unnecessary memory allocation.

In diagonal SDC, the solution and right hand side evaluation is stored at only one collocation node. But also the solution and RHS at the initial conditions is stored and every task stores the solution to the step.
Compared to space-only parallelism at the same number of overall tasks, all solution size objects are larger by the number of tasks in time.
If one uses four tasks in time / four colocation nodes, the solution and RHS evals in diagonal SDC take up $\frac{2\times 4}{5}=1.6$ times the memory compared to space-only parallelism each. And $u_\mathrm{end}$ is four times as large.
The solution size objects therefore require about six times as much memory in diagonal SDC when running in parallel on the same number of tasks compared to space-only parallel. This factor of roughly 6 is also what I measured in actual runs.

@brownbaerchen brownbaerchen added the girl scout rule All you did was leave the campground slightly cleaner than you found it. label Nov 21, 2024
@danielru
Copy link
Member

This is why we contemplated a model that uses OpenMP to parallelize SDC. However, as PF found out, this can be very challenging to get to work within an existing MPI space parallelization.

@pancetta pancetta merged commit 0518f26 into Parallel-in-Time:master Nov 21, 2024
89 checks passed
@brownbaerchen brownbaerchen deleted the parallel_SDC_mem_fix branch November 24, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
girl scout rule All you did was leave the campground slightly cleaner than you found it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants