Hedger #105
Open
Hedger #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrharder
reviewed
Jan 30, 2020
|
|
||
| req = ExchangeOrderRequest(exchange=exchange, id=order_id) | ||
| response = self.em_stub.CancelOrder(req) | ||
| return {'cancelled':True} |
There was a problem hiding this comment.
is there a way to pull the status from the response? or is the response empty?
| import grpc | ||
|
|
||
| ENVIRONMENT = getenv("ENVIRONMENT", 'TEST') | ||
| PRICE_PAIRS = {'WETH/DAI': {'COINBASE': 'ETH/USD'}, |
There was a problem hiding this comment.
(see comment below about adding a config manager to the hedger)
| PRICE_PAIRS = {'WETH/DAI': {'COINBASE': 'ETH/USD'}, | ||
| 'ZRX/DAI': {'COINBASE': 'ZRX/USD'}, 'USDC/USDT': {'BINANCE': 'USDC/USDT'}, | ||
| 'DAI/USDC': {'COINBASE': 'DAI/USDC'}} | ||
| MAX_BOOK_AGES = {'ETH/USD': 10, 'ZRX/USD': 15, 'USDC/USDT': 15, 'DAI/USDC': 25} |
| OBM_CHANNEL = os.environ.get('OBM_CHANNEL', 'localhost:8000') | ||
|
|
||
| try: | ||
| SUPPORTED_EXCHANGES = json.loads(os.environ['SUPPORTED_EXCHANGES']) |
There was a problem hiding this comment.
I know this is carried over from the old impl., but before merge lets move this to the config manger
There was a problem hiding this comment.
^ meaning lets also add a hedger config manager, similar to the maker
| MYSQL_USER = getenv('MYSQL_USER', default=None) | ||
| MYSQL_PASSWORD = getenv('MYSQL_PASSWORD', default=None) | ||
|
|
||
| PRICE_PAIRS = {'WETH/DAI': {'BINANCE': 'ETH/USDT', 'COINBASE': 'ETH/USD'}, 'ZRX/WETH': {'BINANCE': 'ZRX/ETH'}, 'ZRX/DAI': {'COINBASE': 'ZRX/USD', 'BINANCE': 'ZRX/USDT'}} |
There was a problem hiding this comment.
from this line down to 42 should all be through some sort of config manager, like the maker
…transaction parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.