Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filp in/out edges for edgeMapReduce dense operations #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s417-lama
Copy link

If the following edgeMapDense implementation is correct, I think edgeMapReduce_dense and edgeMapCount_dense functions should also flip the in/out edges for the pull operation.

auto neighbors = (fl & in_edges)
? GA.get_vertex(v).out_neighbors()
: GA.get_vertex(v).in_neighbors();

I realized this issue because PageRank produced NaN values because of zero-division when some of the vertices have zero out-degree.
However, this should not happen because the contribution of zero out-degree vertices cannot be propagated to other vertices.

Sorry that I did not test its behavior other than PageRank. This fix may cause some inconsistency in other benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant