Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Select organization on registration #2330

Open
palisadoes opened this issue Jan 16, 2024 · 27 comments
Open

Mobile - Select organization on registration #2330

palisadoes opened this issue Jan 16, 2024 · 27 comments
Labels

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 16, 2024

Is your feature request related to a problem? Please describe.

We are working on migrating the approval of requests to join organizations to a new Admin screen as outlined in this issue:

Prior to this the process was:

  1. New registrants joined the Community
  2. Super Admins would approve the request
  3. Approved registrants would login and select an organization

There were disadvantages to this approach:

  1. This gave too much responsibility to the Super Admin who may not necessarily know people requesting to join in the way an Admin would.
  2. The two step process where the organization was selected post approval, could have been reduced to a simpler single step.

Describe the solution you'd like

TALAWA API

  • This new requirement means that:
    1. New USERs and NON_USERs will need to select an organization when registering so that the request can be directed to the correct organization's Admin screens.
    2. The setup script needs to create a single organization with a generic name on installation to facilitate registration to choice of at least one organization
    3. There can never be less than one organization in the DB
    4. The registration mutation must include organization ID information that issue Add membership request feature for ADMIN  talawa-admin#1416 will be able to detect.
    5. The current GitHub action pull request workflow needs to be updated so that the default organization is created successfully. This is in addition to the already existing test data importation test.
    6. The default organization creation mode mutation needs set the registration approval required flag to True to err on the side of caution.

TALAWA MOBILE

  • This new requirement means that:
    1. The user registration screen(s) will need to prompt for the organization and use the updated Talawa API registration mutation.
    2. The screen(s) design must follow the guidelines of our Design System found here:

TALAWA ADMIN

  • This new requirement means that:
    1. The user registration screen(s) will need to prompt for the organization and use the updated Talawa API registration mutation.
    2. The screen(s) design must follow the guidelines of our Design System found here:

OTHER

  1. You will need to write tests for the updated code
  2. All other functionality must be maintained

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context

  1. Related issues:
    1. API - Select organization on registration talawa-api#1703
    2. Mobile - Select organization on registration #2330
    3. Admin - Select organization on registration talawa-admin#1440
  2. User definitions in the DB schema
    image

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship

@Dante291
Copy link

Dante291 commented Jan 16, 2024

@palisadoes @Cioppolo14 I would like to work on this, please assign me

@AVtheking
Copy link

I would like to work on this issue please assign me this issue

@abhisheksharma010
Copy link

Hello, can you assign this issue to me? I can easily resolve this.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 28, 2024
@palisadoes
Copy link
Contributor Author

Removing issue assignment. No activity. No PR.

@Dante291
Copy link

@palisadoes @Cioppolo14 this need to be fixed from backend side first only then i could work on this, waiting for this PR to get merged, please assign me again.

@palisadoes
Copy link
Contributor Author

@Dante291

  1. The blocking API PR for this issue has been merged.
    1. Signup route changed talawa-api#1741
  2. Please proceed with your work on this with urgency

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 29, 2024
@Dante291
Copy link

@palisadoes since you reverted the PR, I am going to wait for it to get merged again and then will start working on this

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 11, 2024
@Cioppolo14
Copy link

@Dante291 Are you working on this?

@Dante291
Copy link

@Cioppolo14 Yes, this need to be fixed from backend side first only then i will be able to work on this though.

@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Feb 11, 2024
@palisadoes
Copy link
Contributor Author

  1. Be aware of this too. The name and functionality of a mutation will soon change
    1. Support for user to join organizations talawa-api#1859 (comment)

@Dante291 Dante291 removed their assignment Feb 19, 2024
@Azad99-9
Copy link

@Cioppolo14 if this issue is vacant, I would like to work on this. Please assign me.

@Azad99-9
Copy link

@palisadoes please clarify, will the generic organisation always have userRegistrationRequired field set to false. So that the users can directly register into the app.

@palisadoes
Copy link
Contributor Author

You cannot assume this. The Admin team may change that at any time after installation.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 12, 2024
@Cioppolo14
Copy link

Unassigning due to no activity or open PR.

@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Mar 12, 2024
@Azad99-9
Copy link

@Cioppolo14 this issue has a backend dependency. Please have a look, the PR blocking this issue is PalisadoesFoundation/talawa-api#1770

@Cioppolo14
Copy link

@Azad99-9 We are working on getting that one merged.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 24, 2024
@palisadoes
Copy link
Contributor Author

@Azad99-9

The API PR is now complete. You can proceed, if you are available.

PalisadoesFoundation/talawa-api#1703

@Azad99-9
Copy link

Azad99-9 commented Apr 4, 2024

Sure @palisadoes ,@Cioppolo14 please assign me this issue.

@Azad99-9
Copy link

The backend bug needs to be fixed to proceed with this issue.

@Azad99-9
Copy link

PalisadoesFoundation/talawa-api#2242

There is a prerequisite backend issue raised for this issue.

Copy link

github-actions bot commented May 2, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label May 2, 2024
@Azad99-9 Azad99-9 removed their assignment Sep 4, 2024
@github-actions github-actions bot removed the no-issue-activity No issue activity label Sep 5, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Sep 15, 2024
@palisadoes palisadoes added good first issue Good for newcomers and removed test Testing application labels Oct 27, 2024
@github-actions github-actions bot removed the no-issue-activity No issue activity label Oct 28, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants