Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin - Select organization on registration #1440

Closed
palisadoes opened this issue Jan 16, 2024 · 43 comments · Fixed by #1904
Closed

Admin - Select organization on registration #1440

palisadoes opened this issue Jan 16, 2024 · 43 comments · Fixed by #1904
Assignees
Labels
feature request good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 16, 2024

Is your feature request related to a problem? Please describe.

We are working on migrating the approval of requests to join organizations to a new Admin screen as outlined in this issue:

Prior to this the process was:

  1. New registrants joined the Community
  2. Super Admins would approve the request
  3. Approved registrants would login and select an organization

There were disadvantages to this approach:

  1. This gave too much responsibility to the Super Admin who may not necessarily know people requesting to join in the way an Admin would.
  2. The two step process where the organization was selected post approval, could have been reduced to a simpler single step.

Describe the solution you'd like

TALAWA API

  • This new requirement means that:
    1. New USERs and NON_USERs will need to select an organization when registering so that the request can be directed to the correct organization's Admin screens.
    2. The setup script needs to create a single organization with a generic name on installation to facilitate registration to choice of at least one organization
    3. There can never be less than one organization in the DB
    4. The registration mutation must include organization ID information that issue Add membership request feature for ADMIN  #1416 will be able to detect.
    5. The current GitHub action pull request workflow needs to be updated so that the default organization is created successfully. This is in addition to the already existing test data importation test.
    6. The default organization creation mode mutation needs set the registration approval required flag to True to err on the side of caution.

TALAWA MOBILE

  • This new requirement means that:
    1. The user registration screen(s) will need to prompt for the organization and use the updated Talawa API registration mutation.
    2. The screen(s) design must follow the guidelines of our Design System found here:

TALAWA ADMIN

  • This new requirement means that:
    1. The user registration screen(s) will need to prompt for the organization and use the updated Talawa API registration mutation.
    2. The screen(s) design must follow the guidelines of our Design System found here:

OTHER

  1. You will need to write tests for the updated code
  2. All other functionality must be maintained
  3. We will need to add your Figma page designs to our official Figma document

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context

  1. Related issues:
    1. API - Select organization on registration talawa-api#1703
    2. Mobile - Select organization on registration talawa#2330
    3. Admin - Select organization on registration #1440
  2. User definitions in the DB schema
    image

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship

@Sejal1411
Copy link

Would like to contribute! Pls assign.

@karthxk07
Copy link

@palisadoes Can i work on the Talawa-admin part for this, please?

@manishjha-04
Copy link

@palisadoes can i work on this?

@Cioppolo14
Copy link

@Sejal1411 Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@Dcode2100
Copy link

I would like to work on the talawa-admin part of this issue please assign it to me

@Sejal1411
Copy link

@Cioppolo14 I have unassigned myself from one of the issues. Can i get assigned to this issue?

@karthxk07
Copy link

@Sejal1411 i got this issue assigned already , maybe you can work on the api part for the same 👀

@Cioppolo14
Copy link

@Sejal1411 If this issue wasn't already assigned, at this point I could assign you. In the future, if you are first to comment requesting an issue and you really want that issue, make sure you have less than 2 total issues for when I go to do assignments. Thank you for understanding.

@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 21, 2024

@karthxk07

  1. We will need to add your Figma page designs to our official Figma document
  2. Please plan for this

@palisadoes
Copy link
Contributor Author

@karthxk07

  1. The blocking API PR for this issue has been merged.
    1. Signup route changed talawa-api#1741
  2. Please proceed with your work on this with urgency

@karthxk07
Copy link

@palisadoes I had been working on another issue and have been ignorant about this one. I will be immediately on this sir 👍

@karthxk07
Copy link

@palisadoes Sir , in the select organization page, should the user have options to join multiple organizations or only one to start with. Can it be something like this where instead of topics we have organizations ?

image

@palisadoes
Copy link
Contributor Author

One

@karthxk07
Copy link

@palisadoes
Copy link
Contributor Author

How can you make the selection a part of the existing registration screen?

image

@karthxk07
Copy link

karthxk07 commented Feb 2, 2024

@palisadoes Sir, maybe we can add a dropdown field to select from all available organisations?

Something like this? https://www.figma.com/file/6xACotBTh0GU3POVqZbMX0/Untitled?type=design&node-id=0%3A1&mode=design&t=4tJRjxZscGMivMpw-1

image

@palisadoes
Copy link
Contributor Author

OK

@palisadoes
Copy link
Contributor Author

When do you think you'll be able to raise a PR for this?

@karthxk07
Copy link

@palisadoes Sir , I have completed the frontend part , I am working on implementing the logic. I will make the PR ASAP or latest by this weekend.

@karthxk07
Copy link

@palisadoes Sir, Is this signUp mutation behavior expected, because in the above merged blocking PR , the expected output was somewhat different. How should I proceed about this?

Screencast.from.2024-02-08.22-29-31.webm

@palisadoes
Copy link
Contributor Author

If that case comment on the PR's issue with what you'd expect and let's reopen it to have the expected behavior

@palisadoes
Copy link
Contributor Author

However, this PR was created to rectify a previously identified bug.

@palisadoes
Copy link
Contributor Author

@karthxk07

The API PR is now complete. You can proceed. This is could be showstopper issue for new registrations. Do you have time to complete this by the weekend?

@karthxk07
Copy link

@palisadoes That is good news sir. Unfortunately I have exams till the end of the week. But , most of the other work is done so, I can work modestly this week, get done with most work on weekend plus one two more days and make the PR ASAP.

@palisadoes
Copy link
Contributor Author

Good luck with your exams. That comes first. Thanks for the update.

@palisadoes
Copy link
Contributor Author

@karthxk07
Copy link

@palisadoes Yes sir. I have already fixed it locally . This issue will rise for not only the super admin but also for every user trying to register. I will push it up with all the changes.

@karthxk07
Copy link

@palisadoes Sir , there have been a lot of changes to the api repo which has rendered a large part of the admin side inconsistent.

Major problem, The usertype is removed from the login mutation so now we cannot directly see if the user is a ADMIN, SUPERADMIN, or a USER.

How do i proceed further with this?

@palisadoes
Copy link
Contributor Author

The userType methodology was removed. The description of the new way can be found here:

@karthxk07
Copy link

Screencast.from.14-04-24.12.55.33.PM.IST.webm

@palisadoes Sir , this is ready. Does this look fine?

@palisadoes
Copy link
Contributor Author

Yes. Finally!

How does it work with a fresh installation where the LAST_RESORT_SUPERADMIN_EMAIL is set? Where the email address isn't one of the sample data users, for example

@karthxk07
Copy link

@palisadoes Sir , here is how it works for LAST_RESORT_SUPERADMIN_EMAIL.


Screenshot from 2024-04-15 19-15-51

Screencast.from.15-04-24.07.16.02.PM.IST.webm

@palisadoes
Copy link
Contributor Author

Thanks. Please submit a PR

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 26, 2024
@palisadoes palisadoes added the ui/ux issue related and being worked with the figma file of the Admin UI label Apr 27, 2024
@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Development

Successfully merging a pull request may close this issue.

7 participants