-
-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made selection of organization while sign up #2143
made selection of organization while sign up #2143
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@AVtheking, the issue you have referenced to is already closed and no-one is assigned. |
|
Lint fix issue: |
@akhilender-bongirwar I think I have linked correct issue ,you may check again. |
The logic is pretty fine!
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2143 +/- ##
===========================================
+ Coverage 96.75% 96.77% +0.01%
===========================================
Files 342 342
Lines 23116 23115 -1
Branches 2001 2041 +40
===========================================
+ Hits 22366 22369 +3
+ Misses 745 741 -4
Partials 5 5 ☔ View full report in Codecov by Sentry. |
0987209
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
User now selects organization while registering process.
Issue Number:
Fixes #1703
Did you add tests for your changes?
Yes
Summary
userRegistrationRequired
field to true then the membership request would be sent to the organization.Does this PR introduce a breaking change?
No