Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made selection of organization while sign up #2143

Conversation

AVtheking
Copy link

@AVtheking AVtheking commented Apr 2, 2024

What kind of change does this PR introduce?

User now selects organization while registering process.

Issue Number:

Fixes #1703

Did you add tests for your changes?

Yes

Summary

  1. User will select the organization while sign up process.
  2. if the organization has userRegistrationRequired field to true then the membership request would be sent to the organization.

Does this PR introduce a breaking change?

No

Copy link

github-actions bot commented Apr 2, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@akhilender-bongirwar
Copy link
Contributor

@AVtheking, the issue you have referenced to is already closed and no-one is assigned.

@palisadoes
Copy link
Contributor

  1. It's for:
    1. API - Select organization on registration #1703
  2. There is a linting error. An eslint-parser upgrade was recently merged. We'll need to open an issue to fix this

@palisadoes
Copy link
Contributor

@AVtheking
Copy link
Author

@AVtheking, the issue you have referenced to is already closed and no-one is assigned.

@akhilender-bongirwar I think I have linked correct issue ,you may check again.

@Manik2708
Copy link

The logic is pretty fine! adminApproved is getting removed, which solves most of the confusion. But as I discussed with @palisadoes, we need to ensure that only those new users should be allowed into Talawa which are approved by the organization chosen at the time of sign up. So once this PR is merged we need to work on:

  1. Introducing a variable which will check, whether user is validated by admins of organization or not. If not validated, then user should not be allowed to enter Talawa.
  2. If rejected, giving user an option to re-select the organization after login.
  3. When rejected multiple times by different organizations, marking user as spam.
    This will ensure that only serious users are in the Talawa ecosystem.

@palisadoes
Copy link
Contributor

  1. @AVtheking Please fix the failing tests.
  2. @Manik2708 All good points. We can add the validation logic after this basic functionality is added.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 98.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.77%. Comparing base (1faccc7) to head (5276968).

Files Patch % Lines
src/resolvers/Mutation/signUp.ts 98.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2143      +/-   ##
===========================================
+ Coverage    96.75%   96.77%   +0.01%     
===========================================
  Files          342      342              
  Lines        23116    23115       -1     
  Branches      2001     2041      +40     
===========================================
+ Hits         22366    22369       +3     
+ Misses         745      741       -4     
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes merged commit 0987209 into PalisadoesFoundation:develop Apr 4, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants