Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix User Update Profile #1847

Closed
wants to merge 3 commits into from
Closed

fix User Update Profile #1847

wants to merge 3 commits into from

Conversation

Shubh152
Copy link

@Shubh152 Shubh152 commented Feb 12, 2024

What kind of change does this PR introduce?

bugfix

Issue Number:

Fixes PalisadoesFoundation/talawa-admin#1508

Did you add tests for your changes?

Yes

Snapshots/Videos:

If relevant, did you update the documentation?

No

Summary

PalisadoesFoundation/talawa-admin#1508

Does this PR introduce a breaking change?

Other information

Another PR needs to be merged in talawa-admin repo to fix the issue completely
PalisadoesFoundation/talawa-admin#1573

Corresponding issue int talawa-api
Fixes #1834

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@Cioppolo14
Copy link
Contributor

@Shubh152 There should be an issue related to talawa-api to link to. Please create one if there is not.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 128 lines in your changes are missing coverage. Please review.

Comparison is base (c0468a4) 98.17% compared to head (01b41ae) 97.90%.
Report is 303 commits behind head on develop.

Files Patch % Lines
src/resolvers/Mutation/removeUserFromUserFamily.ts 82.17% 22 Missing and 1 partial ⚠️
src/resolvers/Mutation/addUserToUserFamily.ts 78.04% 18 Missing ⚠️
src/resolvers/Mutation/updateUserProfile.ts 73.43% 1 Missing and 16 partials ⚠️
src/libraries/errors/ImageSizeLimitExceeded.ts 27.27% 16 Missing ⚠️
src/resolvers/Mutation/createEvent.ts 83.51% 13 Missing and 2 partials ⚠️
src/resolvers/middleware/currentUserExists.ts 45.83% 13 Missing ⚠️
src/libraries/logger.ts 16.66% 10 Missing ⚠️
src/resolvers/Mutation/createPost.ts 90.32% 6 Missing ⚠️
src/resolvers/Mutation/createOrganization.ts 95.78% 4 Missing ⚠️
src/resolvers/Mutation/removeAdvertisement.ts 92.85% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1847      +/-   ##
===========================================
- Coverage    98.17%   97.90%   -0.28%     
===========================================
  Files          184      234      +50     
  Lines        10767    14131    +3364     
  Branches       835     1178     +343     
===========================================
+ Hits         10571    13835    +3264     
- Misses         186      262      +76     
- Partials        10       34      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

schema.graphql Outdated Show resolved Hide resolved
schema.graphql Outdated Show resolved Hide resolved
schema.graphql Outdated Show resolved Hide resolved
@palisadoes
Copy link
Contributor

NOTE Read very carefully

  1. We just merged this PR which upgraded the prettier package.
    1. Upgraded prettier from version 2.8,8 to 3.2.5. #1840
  2. It reformatted over 400 files. This will put your PR at risk of extensive merge conflicts.
  3. I suggest that before you merge your code to the latest upstream, or manually fix these merge conflicts that you:
    1. upgrade your prettier in your local branch to the same version
    2. run prettier

This will help to reduce the number of future merge conflicts for your PR.

@xoldd
Copy link
Contributor

xoldd commented Feb 18, 2024

@palisadoes same as PR #1762 should be closed

@palisadoes palisadoes closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants