-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix User Update Profile #1847
fix User Update Profile #1847
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
@Shubh152 There should be an issue related to talawa-api to link to. Please create one if there is not. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1847 +/- ##
===========================================
- Coverage 98.17% 97.90% -0.28%
===========================================
Files 184 234 +50
Lines 10767 14131 +3364
Branches 835 1178 +343
===========================================
+ Hits 10571 13835 +3264
- Misses 186 262 +76
- Partials 10 34 +24 ☔ View full report in Codecov by Sentry. |
NOTE Read very carefully
This will help to reduce the number of future merge conflicts for your PR. |
@palisadoes same as PR #1762 should be closed |
What kind of change does this PR introduce?
bugfix
Issue Number:
Fixes PalisadoesFoundation/talawa-admin#1508
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
No
Summary
PalisadoesFoundation/talawa-admin#1508
Does this PR introduce a breaking change?
Other information
Another PR needs to be merged in talawa-admin repo to fix the issue completely
PalisadoesFoundation/talawa-admin#1573
Corresponding issue int talawa-api
Fixes #1834
Have you read the contributing guide?
Yes