-
-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated location Param to Address Object param in Organizations (Updated). #1740
Merged
palisadoes
merged 22 commits into
PalisadoesFoundation:develop
from
Anubhav-2003:Issue_1650
Jan 27, 2024
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c5ce942
Made changes to the Organization location parameter in both types and…
Anubhav-2003 1702d25
Added tests for the changes
Anubhav-2003 19b4192
Changed sample data
Anubhav-2003 e93673b
Changed data in sample_data
Anubhav-2003 0efb279
Fixed the failing tests
Anubhav-2003 11753f0
Merge branch 'develop' into Issue_1650
Anubhav-2003 d6ff936
Fixed linting issues
Anubhav-2003 0643cc6
Added extra tests
Anubhav-2003 a3adebe
Made address compulsory for organizations
Anubhav-2003 d4b56d2
Removed IsPublic param
Anubhav-2003 566a846
Merge branch 'develop' into Issue_1650
Anubhav-2003 d2813b2
Made AddressInput Non-nullable
Anubhav-2003 3bd0140
Added address to sample organizations
Anubhav-2003 995ee14
Merge branch 'develop' into Issue_1650
Anubhav-2003 1757e0b
Updated createSampleOrg utility functions
Anubhav-2003 aedee07
Changed countryCode type to string
Anubhav-2003 161ce7c
Updated the inputType for UpdateOrganization Mutation
Anubhav-2003 e2cbeb8
Restored creatorId for sample organizations
Anubhav-2003 4be5e62
Made line2,and sortingcode optional in address
Anubhav-2003 c3a6264
Made countrycode and city mandatory fields, rest optional
Anubhav-2003 c1ec450
Fixed a bug in tests
Anubhav-2003 1080e53
Fixed test cases
Anubhav-2003 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirm which fields are non nullable and add
required: true
to themThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sir, I will make those two mandatory. As for the enums, I have already hardcoded an entire list of objects with country codes and country names in the admin portal for the drop down list. I found that creating an object would be more self-explanatory and better as compared to just an enum. you can find that change in the other PR. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@palisadoes @xoldyckk Respected sir, I have made the changes requested, and made countrycode, and city mandatory. But due to this change. Some tests are failing. I will be fixing those tests as early as possible.
Thank You.