Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org Admins must be able to edit member information for their organizations #1752

Closed
Anvita0305 opened this issue Jan 28, 2024 · 22 comments
Closed
Labels
bug Something isn't working

Comments

@Anvita0305
Copy link

Describe the bug

  1. The Admin of an Organization must be able to change other members role.
  2. Currently only the SuperAdmin is able to do so.

Expected behavior

  1. The admin must also be able to change the roles of the members

Actual behavior

  1. Only superadmin is able to update the roles in the org, not the admin.

Screenshots
This is the screenshot from Admin portal. Whenever the admin tries to update the role, this error is encountered.
Screenshot from 2024-01-28 19-52-08

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@Anvita0305 Anvita0305 added the bug Something isn't working label Jan 28, 2024
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@jayantpranjal0
Copy link

@palisadoes Can I work on this issue?

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Jan 30, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 10, 2024
@Cioppolo14
Copy link
Contributor

Unassigning due to no activity or PR.

@MSVaibhav4141
Copy link

@Cioppolo14
Sir,I already have two assigned issues; I believe one of them is a duplicate, and the other one is assigned to me. Could you please review the issue #1697 assigned to me and reassign me to the issue referenced within that task? This way, I would be left with only one workable issue.
So sir Can I work on this issue?

@Cioppolo14
Copy link
Contributor

@MSVaibhav4141 I closed the duplicate. In the future, you can unassign yourself, please just leave a comment that you are doing so, it helps us keep tracking. Thank you!

@MSVaibhav4141
Copy link

Working on it

@MSVaibhav4141
Copy link

@Anvita0305 Have you worked on it ? I may need a slight assistance

@MSVaibhav4141
Copy link

@Cioppolo14 I have tried to change superAdminCheck() to normal adminCheck() under

src\resolvers\Mutation\createAdmin.ts
on line 67

like this
image

But then also it's still throwing me the same error on adding a user to admin with admin previlage
This is the error user not authorized

image

any assistance would be greatly appreciated.
Thanks:)

@Anvita0305
Copy link
Author

@Anvita0305 Have you worked on it ? I may need a slight assistance

No @MSVaibhav4141 , I have worked on the frontend.

@MSVaibhav4141
Copy link

@Anvita0305 Have you worked on it ? I may need a slight assistance

No @MSVaibhav4141 , I have worked on the frontend.

@Anvita0305
Ohkk.. however any suggestions on the issue I am facing

Copy link

github-actions bot commented Mar 3, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 3, 2024
@palisadoes
Copy link
Contributor

  1. Unassigning due to inactivity. No submitted PR
  2. This is open for reassignment, preferably to someone with an active GitHub profile on the technologies used or experience with the repository

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 4, 2024
@ryuga001
Copy link

ryuga001 commented Mar 4, 2024

@palisadoes Can I work on this issue?

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 15, 2024
@palisadoes
Copy link
Contributor

Unassigning, not activity or PR

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 16, 2024
@Anubhav-2003
Copy link
Contributor

Anubhav-2003 commented Mar 16, 2024

@palisadoes Respected sir, I would like to work on this issue.

@Anvita0305
Copy link
Author

Hey @Anubhav-2003, I had created this issue based on the information available here https://docs.talawa.io/docs/introduction/core-concepts. I have also attached screenshot for reference.
image
Hope it helps!

@Anubhav-2003
Copy link
Contributor

@Anvita0305 ok anvita, thanks for the help.

@Anubhav-2003 Anubhav-2003 removed their assignment Mar 26, 2024
@Anubhav-2003
Copy link
Contributor

unassigned myself, as this issue cannot be solved unless this issue #2084 and PalisadoesFoundation/talawa-admin#1765 are solved. I have solved the first one. Once its PR is merged, I will come back. Thank You.

@pranshugupta54
Copy link
Member

Can not reproduce, it works properly.

  • Tried changing the role from USER to ADMIN and vice-versa using Admin's authentication and works perfectly.
image

Note: If you are talking about the issue on frontend, then the design is changed and yet to be completed. Currently admins dont have a way to change role, it will be implemented soon.

@palisadoes
Copy link
Contributor

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants