Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when updation of talawa admin members profile. #1750

Closed
Devesh326 opened this issue Jan 28, 2024 · 14 comments
Closed

Unexpected behavior when updation of talawa admin members profile. #1750

Devesh326 opened this issue Jan 28, 2024 · 14 comments
Labels
bug Something isn't working GSoC Priority

Comments

@Devesh326
Copy link

Devesh326 commented Jan 28, 2024

Describe the bug

This bug report pertains to an issue encountered in the Talawa-Admin platform, where:

  1. When attempting to update a member's profile, it seems to require changing the email ID.
  2. Despite updating the profile, the member's actual profile remains unchanged. Instead, the user's (your) profile credentials are updated to match the member's credentials.

Issue Link raised in Talawa Admin repository
PalisadoesFoundation/talawa-admin#1473

To Reproduce
Steps to reproduce the behavior:

  1. Open Talawa Admin website
  2. Click on your profile at the bottom left
  3. Click People Tab on the sidebar
  4. Press users checkbox and update a members profile

Expected behavior

  1. When a user updates a member's profile, the member's profile should get updated even if only the name is edited.
  2. After updating the member's profile, it should not affect the user's (your) profile.

Additional details
Modifications have been made in Talawa-Admin to address this issue, which also requires corresponding adjustments in Talawa-API.
Can i work on this issue?

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@Devesh326 Devesh326 added the bug Something isn't working label Jan 28, 2024
@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Jan 28, 2024
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Jan 28, 2024
@Cioppolo14
Copy link
Contributor

@Devesh326 Is #1752 related to this issue?

@Devesh326
Copy link
Author

@Devesh326 Is #1752 related to this issue?

No, in this particular issue, even if the superadmin tries to update the member's profile, it doesnt get updated. Rather the root user's profile gets updated. I have fixed the issue from the frontend but it also requires some changes in the backend.

@xoldd
Copy link
Contributor

xoldd commented Feb 1, 2024

@Devesh326 should a superadmin be allowed to edit any field of any user's profile?

and even if they are, the resolver logic is incorrect, there is no check in place for whether the person trying to update the profile is a superadmin or not

@palisadoes
Copy link
Contributor

@xoldyckk

It's a question of trust. Just like a bank customer service representative can modify your account information, just like you can in the banking app.

We will need to figure out how protections should be done in practice, but the basic editing capability is needed at this stage

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

Copy link

github-actions bot commented Mar 9, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@palisadoes
Copy link
Contributor

  1. Unassigning due to an abandoned PR. This is available.
  2. @Devesh326 let us know whether you'd like to be reassigned. There has been no activity in the PR for over a month so I decided to close it
    1. Fixed #1750: Unexpected behavior when updation of talawa admin members profile.  #1762

@palisadoes
Copy link
Contributor

We are tracking this issue with one of our projects, and we'd like to track its progress especially as the GSoC announcement dates draw near.

  1. When you create your PR, please link it back to this project:
    1. https://github.com/orgs/PalisadoesFoundation/projects/24/views/1
  2. The process is simple. It can be found here:
    1. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-to-an-issue-using-the-pull-request-sidebar

@varshith257
Copy link
Member

@palisadoes Seems @Devesh326 had no activity in his GitHub profile for a month, I would like to complete this issue as a GSOC Priority issue. Please assign this issue to me

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 25, 2024
@Cioppolo14
Copy link
Contributor

@varshith257 You have a lot of open issues & PRs, let's focus on those and give someone else a chance. I will work on getting reviews on your PRs. Thank you for your enthusiasm and contributions.

@nikhil-pandey-digital
Copy link
Contributor

hie @palisadoes @Cioppolo14 I would love to fix this issue, please assign this issue to me.

@palisadoes
Copy link
Contributor

unassigning. Inactivity

@pranshugupta54
Copy link
Member

@Devesh326, Is this still an issue? We've re-designed this page and it works.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GSoC Priority
Projects
Development

No branches or pull requests

8 participants