Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Input Field Outline Display Issue #989

Conversation

TusharKumawat1
Copy link

My pull request resolves the issue of a hidden bottom outline of the input field, ensuring proper display and user-friendliness.

What kind of change does this PR introduce?

This pull request addresses a bug related to the styling.

Issue Number:

Fixes #988

Did you add tests for your changes?

After testing, I can confirm that the issue has been resolved and I have provided a video as evidence.

Snapshots/Videos:

resolved.issue988.mp4

Summary

This pull request not only fixes the issue of the hidden bottom outline in the input field but also enhances the overall user interface, making it more visually appealing and user-friendly.

I'm excited to submit my first pull request for Palisadoes Foundation. I'm looking forward to contributing to their projects, I'm particularly interested in exploring other opportunities within the organization as well.

Have you read the contributing guide?

YES

@github-actions
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@github-actions
Copy link

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No pull request activity label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #989 (d91c498) into develop (12f210b) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #989   +/-   ##
========================================
  Coverage    94.37%   94.37%           
========================================
  Files          123      123           
  Lines         2647     2647           
  Branches       709      709           
========================================
  Hits          2498     2498           
  Misses         141      141           
  Partials         8        8           
Files Coverage Δ
src/screens/ForgotPassword/ForgotPassword.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@palisadoes
Copy link
Contributor

We are now focusing on three types of issues as priority areas:

  1. The improvement in the reliability of our code base. There are many issues created to test existing code. It is a good place to start if you want to understand the operation of various apps. When you submit PRs, we automatically check to see whether the code you submitted has been covered by testing and that each file meets the minimum standard level of the repository as a whole. You won’t be able to avoid understanding testing regimes to contribute to Talawa.
  2. The fixing of bugs and features that seriously hamper the user from using the application. The apps have various shortcomings. The most obvious ones are where the apps do not work as expected. For example buttons that don’t work, errors or messages that are not displayed to make the user understand what to do and many more. Think of any difficulty you have had in getting things working, there could be a bug there waiting for you.
  3. Coding of screens for issues created by our Contributor team based on our soon to be updated design guide. This may include updates to existing screens. Stay tuned, we expect these issues to be created during the first week of November 2023. @rishav-jha-mech is leading this process for the Talawa Admin project
  4. The creation of additional our updated documentation that helps with improving both the experience of the end user and the various GitHub contributors who support the development of our software. This would include user guides.

We will only be accepting feature issues for deficiencies that are obviously lacking in the apps. These are things that make it very difficult to operate the apps. Even so, the PRs will still require you to understand testing as stated before.

Closing in anticipation of our work on the design. Responsiveness will be a part of this re-evaluation.

@palisadoes palisadoes closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity No pull request activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: Input Field Outline Display Issue
2 participants