-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(933): refetching in /orgpost after deleting a post #962
fix(933): refetching in /orgpost after deleting a post #962
Conversation
…l-fix-933-refetching-in-orgpost
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
@ThePiyushAggarwal Please write the appropriate tests to verify your work |
Ok. I will write the tests. I have some experience with testing but not much. I plan to complete this by end of this week. |
Codecov Report
@@ Coverage Diff @@
## develop #962 +/- ##
===========================================
- Coverage 94.69% 94.69% -0.01%
===========================================
Files 111 111
Lines 2339 2338 -1
Branches 611 611
===========================================
- Hits 2215 2214 -1
Misses 117 117
Partials 7 7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This has already been taken care of , under the revamp of newsfeed managament @palisadoes @ThePiyushAggarwal |
@aashimawadhwa Can you please point me to the PR/branch for this resolved issue? |
@palisadoes Shall I close the PR if it is not required? |
@JamaicanFriedChicken @jordan-barrett-jm Pleases review |
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
Closing as @aashimawadhwa is already working on this |
In the /orgpost page, posts are listed but after deleting a post, the page was being reloaded to fetch the latest posts. This was a bad UX.
I have made use of
refetchQueries
method from the hooks provided by@apollo/client
, it will delete the post and fetch latest data and then complete the process. This actually makes it a lot faster than before.What kind of change does this PR introduce?
Fix
Issue Number:
Fixes #933
Did you add tests for your changes?
No. Not required.
Snapshots/Videos:
talawa-delete-post-refetching.webm
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes