Refactor: src/screens/OrganizationTags/OrganizationTags.test.tsx from Jest to Vitest #3078
Conversation
WalkthroughThis pull request focuses on refactoring the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/screens/UserPortal/Settings/Settings.tsx (1)
129-139: Provide user feedback on invalid birth date selection.While logging an error to the console prevents state updates for future birth dates, the user receives no direct UI feedback. Consider rendering a localized error message or a subtle UI prompt to guide users toward a valid date selection.
src/components/UsersTableItem/UserTableItem.test.tsx (1)
18-18: Remove unuseditimport.
According to the static analysis hint,itis never referenced in the tests. Eliminating unused imports will keep the code clean.- import { vi, beforeEach, afterEach, describe, it, expect } from 'vitest'; + import { vi, beforeEach, afterEach, describe, expect } from 'vitest';🧰 Tools
🪛 eslint
[error] 18-18: 'it' is defined but never used.
(@typescript-eslint/no-unused-vars)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/components/UsersTableItem/UserTableItem.test.tsx(3 hunks)src/screens/OrganizationTags/OrganizationTags.test.tsx(3 hunks)src/screens/UserPortal/Settings/Settings.spec.tsx(1 hunks)src/screens/UserPortal/Settings/Settings.tsx(2 hunks)
🧰 Additional context used
📓 Learnings (1)
src/components/UsersTableItem/UserTableItem.test.tsx (1)
Learnt from: bitbard3
PR: PalisadoesFoundation/talawa-admin#2588
File: src/components/ChangeLanguageDropdown/ChangeLanguageDropdown.spec.tsx:145-155
Timestamp: 2024-12-02T04:20:11.745Z
Learning: In PRs focused solely on refactoring test cases from Jest to Vitest, avoid suggesting optimizations or changes outside the migration scope.
🪛 eslint
src/components/UsersTableItem/UserTableItem.test.tsx
[error] 18-18: 'it' is defined but never used.
(@typescript-eslint/no-unused-vars)
🔇 Additional comments (11)
src/screens/UserPortal/Settings/Settings.spec.tsx (1)
414-445: Well-structured birth date future-date test.
The newly added test effectively verifies that future dates are disallowed and ensures the birth date input field remains unchanged when a future date is set. As a further enhancement, consider adding edge-case tests (e.g., partial/invalid date input) to reinforce date validation coverage.
src/screens/UserPortal/Settings/Settings.tsx (1)
465-465: Check local time zones with the 'max' attribute.
Using new Date().toISOString().split('T')[0] places a strict UTC-based bound on the date picker, which may lead to slight off-by-one issues in other time zones. If relevant for the user base, consider adjusting the logic or clarifying time zone expectations in the UI.
src/screens/OrganizationTags/OrganizationTags.test.tsx (4)
14-14: Migrated import to Vitest successfully.
This import of vi aligns with the transition away from Jest to Vitest.
47-50: Switched mocking of react-toastify to use vi.mock.
This change correctly follows Vitest’s mocking API.
80-86: Updated react-router-dom mock to Vitest.
Using vi.mock and importActual is a valid approach for seamlessly mocking useParams.
90-90: Replaced jest.clearAllMocks() with vi.clearAllMocks().
This ensures that all mocks are cleared between test runs under Vitest.
src/components/UsersTableItem/UserTableItem.test.tsx (5)
31-31: Use of vi.fn() is correct.
The transition from jest.fn() to vi.fn() for resetAndRefetchMock is properly executed.
33-37: Mocking react-toastify with Vitest.
These lines correctly switch from jest.mock() to vi.mock(), and from jest.fn() to vi.fn().
49-51: Mocking react-router-dom with Vitest.
Replacing jest.mock('react-router-dom') with vi.mock('react-router-dom') is consistent with the migration.
62-62: Replaced jest.clearAllMocks() with vi.clearAllMocks().
This ensures no stale mocks persist between tests under Vitest.
66-66: Redirecting console.error to vi.fn().
Use of Vitest for stubbing out console errors is correct and helps in controlling test output.
|
Please fix the conflicting file |
Reopening |
|
i found the reason of conflict i will change the issue with a new commit |
|
Please fix the new conflicting file |
arpit-chakraborty
force-pushed
the
arpit-chakraborty#3071develop-postgre
branch
from
c777abe to
4341660
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3078 +/- ##
=====================================================
+ Coverage 26.39% 89.09% +62.70%
=====================================================
Files 301 322 +21
Lines 7588 8421 +833
Branches 1657 1897 +240
=====================================================
+ Hits 2003 7503 +5500
+ Misses 5454 676 -4778
- Partials 131 242 +111 ☔ View full report in Codecov by Sentry. |
palisadoes
merged commit ff5663e
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Refactor: src/screens/OrganizationTags/OrganizationTags.test.tsx from Jest to Vitest
Issue Number:
Fixes #3071
Did you add tests for your changes?
yes
Snapshot
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Testing
react-toastifyandreact-router-domRefactor