Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of Donations Page #1846

Merged
merged 42 commits into from
Apr 3, 2024

Conversation

git-init-priyanshu
Copy link
Member

@git-init-priyanshu git-init-priyanshu commented Mar 29, 2024

What kind of change does this PR introduce?
UI redesign.

Issue Number:
Fixes #1513

Did you add tests for your changes?
Not yet

Summary

  1. Redesigned the user donation page.
  2. Added donate feature.
  3. Search functionality does not work.
  4. The image of the donation card is temporary.

Snapshots/Videos:
image

If relevant, did you update the documentation?
No

Does this PR introduce a breaking change?
No

Have you read the contributing guide?
yes

git-init-priyanshu and others added 30 commits January 26, 2024 21:28
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@git-init-priyanshu
Copy link
Member Author

Hey @aashimawadhwa Can you please clarify a few things:

  1. What should be included in the image section of the donation card?
  2. How will the search function operate?

@Cioppolo14
Copy link
Contributor

@git-init-priyanshu Please fix the failing checks and add tests as needed.

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You have disabled all linting.
  2. Please fix

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore all linting

.eslintrc.json Outdated
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-inferrable-types": "off",
"@typescript-eslint/no-non-null-asserted-optional-chain": "off",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore all linting

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (1d057d9) to head (99d9836).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1846   +/-   ##
========================================
  Coverage    98.26%   98.27%           
========================================
  Files          198      198           
  Lines         5079     5094   +15     
  Branches      1491     1492    +1     
========================================
+ Hits          4991     5006   +15     
+ Misses          83       82    -1     
- Partials         5        6    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes self-requested a review April 3, 2024 19:52
@palisadoes palisadoes merged commit b313f80 into PalisadoesFoundation:develop Apr 3, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants