Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict lint and update PR workflow #1700

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Strict lint and update PR workflow #1700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d649dd6
strict lint and update PR workflow
lakshz Mar 10, 2024
f951b24
Merge branch 'develop' of github.com:PalisadoesFoundation/talawa-admi…
lakshz Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@
"eslint-plugin-tsdoc"
],
"rules": {
"react/destructuring-assignment": ["off"],
// "@typescript-eslint/no-explicit-any": ["off"],
"@typescript-eslint/explicit-module-boundary-types": ["off"],
"react/destructuring-assignment": "error",
"@typescript-eslint/explicit-module-boundary-types": "error",
"react/no-multi-comp": [
"error",
{
Expand All @@ -54,7 +53,7 @@
"import/no-duplicates": "error",
"tsdoc/syntax": "error",
"@typescript-eslint/ban-ts-comment": "error",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-explicit-any": "error",
"@typescript-eslint/no-inferrable-types": "error",
"@typescript-eslint/no-non-null-asserted-optional-chain": "error",
"@typescript-eslint/no-non-null-assertion": "error",
Expand Down Expand Up @@ -126,6 +125,7 @@
// All tests must need not have an assertion
"jest/expect-expect": 0,

"react/jsx-indent": ["error", 2],
"react/jsx-tag-spacing": [
"warn",
{
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,11 @@ jobs:
if: steps.changed-files.outputs.only_changed != 'true'
run: npm run typecheck

- name: Run linting check
- name: Check for linting errors in modified files
if: steps.changed-files.outputs.only_changed != 'true'
run: npm run lint:check
env:
CHANGED_FILES: ${{ steps.changed_files.outputs.all_changed_files }}
run: npx eslint ${CHANGED_FILES}

- name: Check for localStorage Usage
run: |
Expand Down
Loading
Loading