-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strict lint and update PR workflow #1673
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1673 +/- ##
===========================================
- Coverage 97.41% 97.39% -0.02%
===========================================
Files 164 168 +4
Lines 4058 4148 +90
Branches 1177 1210 +33
===========================================
+ Hits 3953 4040 +87
- Misses 101 104 +3
Partials 4 4 ☔ View full report in Codecov by Sentry. |
@lakshz Please fill out the PR template as thoroughly as possible. In the future, please do not assign reviewers. We have queue monitors who do an initial check of the PR, and then assign reviewers when it is ready. |
@Tajcore @beingnoble03 Can you review this PR? |
@Cioppolo14 Got it, I updated the PR comment. |
You will see that other PRs are using non-develop branch names for this reason |
What kind of change does this PR introduce?
Stricts the lint config to consider
no-explicit-any
as an error.Updated PR workflow:
Updated pre-commit script:
lint-staged
configuration was added inpackage.json
file, taking helptalawa-api
project.Issue Number:
Fixes #1427
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?