Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Admin button functionality #1509

Merged
merged 23 commits into from
Feb 3, 2024

Conversation

Anvita0305
Copy link

What kind of change does this PR introduce?
Bugfix

Issue Number:

Fixes #1507

Did you add tests for your changes?

No

Snapshots/Videos:
Screencast from 28-01-24 07:08:08 PM IST.webm

Summary

a. For Superadmin role:

  1. Add Admin button was not working correctly. Now it is adding the admin for an org correctly.
  2. The button was clickable although the current role was Admin. Now if the role is admin or superadmin, the button get disabled.
    b. For Admin role:
  3. The UI is same hence all the changes are replicated.

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f4e5e1) 96.23% compared to head (d7a71f8) 96.24%.
Report is 2 commits behind head on develop.

❗ Current head d7a71f8 differs from pull request most recent head 4861f1a. Consider uploading reports for the commit 4861f1a to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1509   +/-   ##
========================================
  Coverage    96.23%   96.24%           
========================================
  Files          133      133           
  Lines         3404     3408    +4     
  Branches      1031     1031           
========================================
+ Hits          3276     3280    +4     
  Misses         123      123           
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Anvita0305
Copy link
Author

Here for Admin role, the admin is not permitted to update the role of other member in same organization. This needs to be changed in talawa-api repo. So should I open a new issue there for the same?
image

@palisadoes
Copy link
Contributor

Yes, create the issue. Org Admins must be able to edit member information for their organizations

@palisadoes
Copy link
Contributor

Please fix the failing tests

  1. Code coverage
  2. Introspection

@Anvita0305
Copy link
Author

Hello @palisadoes sir, I have updated the failing tests however the introspection test is failing even after fetching the latest code. Can you please give suggestions for rectifying it?

@palisadoes
Copy link
Contributor

  1. When you click on the link of the failing test you see that UserToReturn is missing. This is in the API repo, but Admin doesn't have code to recognize it.
  2. This is probably due to a recent API merge
  3. You'll need to add the code

image

@Anvita0305
Copy link
Author

Ok will add the code. Thanks!

@Anvita0305
Copy link
Author

Anvita0305 commented Feb 1, 2024

Hello @palisadoes sir, the introspection test which was failing due to 'UserToReturn' was fixed by merging the latest code. However now, it is failing because fields 'id' and 'applangcode' is not defined by type UpdateUserInput. However this issue will get fixed in PalisadoesFoundation/talawa-api#1762.

@Cioppolo14
Copy link

@rishav-jha-mech @Kevoniat Can you review this PR?

@aashimawadhwa
Copy link
Member

I think if the introspection workflow failure is related to the api issue, then this can be merged @palisadoes

@palisadoes palisadoes merged commit ddc7e42 into PalisadoesFoundation:develop Feb 3, 2024
7 of 8 checks passed
@Anvita0305 Anvita0305 deleted the develop4 branch February 9, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants