-
-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected Admin button functionality #1509
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1509 +/- ##
========================================
Coverage 96.23% 96.24%
========================================
Files 133 133
Lines 3404 3408 +4
Branches 1031 1031
========================================
+ Hits 3276 3280 +4
Misses 123 123
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Yes, create the issue. Org Admins must be able to edit member information for their organizations |
Please fix the failing tests
|
Hello @palisadoes sir, I have updated the failing tests however the introspection test is failing even after fetching the latest code. Can you please give suggestions for rectifying it? |
Ok will add the code. Thanks! |
Hello @palisadoes sir, the introspection test which was failing due to 'UserToReturn' was fixed by merging the latest code. However now, it is failing because fields 'id' and 'applangcode' is not defined by type UpdateUserInput. However this issue will get fixed in PalisadoesFoundation/talawa-api#1762. |
@rishav-jha-mech @Kevoniat Can you review this PR? |
I think if the introspection workflow failure is related to the api issue, then this can be merged @palisadoes |
What kind of change does this PR introduce?
Bugfix
Issue Number:
Fixes #1507
Did you add tests for your changes?
No
Snapshots/Videos:
Screencast from 28-01-24 07:08:08 PM IST.webm
Summary
a. For Superadmin role:
b. For Admin role:
Have you read the contributing guide?
Yes